-
Notifications
You must be signed in to change notification settings - Fork 19
RHOAIENG-28547: add TeX Live and Pandoc installation for ppc64le #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rhoai-2.23-multi-arch-poc
Are you sure you want to change the base?
RHOAIENG-28547: add TeX Live and Pandoc installation for ppc64le #1318
Conversation
Signed-off-by: puneetsharma21 <[email protected]>
Hi @puneetsharma21. Thanks for your PR. I'm waiting for a red-hat-data-services member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
…ppc64le Signed-off-by: puneetsharma21 <[email protected]>
…dencies on ppc64le Signed-off-by: puneetsharma21 <[email protected]>
/ok-to-test |
Signed-off-by: puneetsharma21 <[email protected]>
/ok-to-test |
2 similar comments
/ok-to-test |
/ok-to-test |
jupyter/utils/install_texlive.sh
Outdated
# Install build dependencies | ||
dnf install -y https://mirror.stream.centos.org/9-stream/BaseOS/ppc64le/os/Packages/centos-gpg-keys-9.0-24.el9.noarch.rpm \ | ||
https://mirror.stream.centos.org/9-stream/BaseOS/`arch`/os/Packages/centos-stream-repos-9.0-24.el9.noarch.rpm \ | ||
https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm | ||
dnf config-manager --add-repo https://mirror.stream.centos.org/9-stream/BaseOS/ppc64le/os | ||
dnf config-manager --add-repo https://mirror.stream.centos.org/9-stream/AppStream/ppc64le/os | ||
dnf config-manager --set-enabled crb | ||
dnf install -y gcc-toolset-13 perl make libX11-devel libXt-devel \ | ||
zlib-devel freetype-devel libpng-devel ncurses-devel \ | ||
gd-devel libtool wget tar xz bison flex libXaw-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but no, this is not permitted, UBI and CentOS may not be mixed in anything that Red Hat does, that's against Red Hat policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiridanek Thanks for pointing this out.
I've now removed CentOS repository configuration from the script. Instead, I'm directly installing only the required packages via RPMs (from CentOS Stream) using rpm -ivh --nodeps, and only for those not available in UBI.
…BI compatibility Signed-off-by: puneetsharma21 <[email protected]>
Signed-off-by: puneetsharma21 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@puneetsharma21: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/ok-to-test |
rpm -q libXmu-devel || rpm -ivh --nodeps https://mirror.stream.centos.org/9-stream/AppStream/ppc64le/os/Packages/libXmu-devel-1.1.3-8.el9.ppc64le.rpm | ||
rpm -q libXext-devel|| rpm -ivh --nodeps https://mirror.stream.centos.org/9-stream/AppStream/ppc64le/os/Packages/libXext-devel-1.3.4-8.el9.ppc64le.rpm | ||
rpm -q libICE-devel || rpm -ivh --nodeps https://mirror.stream.centos.org/9-stream/AppStream/ppc64le/os/Packages/libICE-devel-1.0.10-8.el9.ppc64le.rpm | ||
rpm -q libSM-devel || rpm -ivh --nodeps https://mirror.stream.centos.org/9-stream/AppStream/ppc64le/os/Packages/libSM-devel-1.2.3-10.el9.ppc64le.rpm | ||
rpm -q libXmu || rpm -ivh --nodeps https://mirror.stream.centos.org/9-stream/AppStream/ppc64le/os/Packages/libXmu-1.1.3-8.el9.ppc64le.rpm | ||
rpm -q libXaw-devel || rpm -ivh --nodeps https://mirror.stream.centos.org/9-stream/AppStream/ppc64le/os/Packages/libXaw-devel-1.0.13-19.el9.ppc64le.rpm | ||
rpm -q libXaw || rpm -ivh --nodeps https://mirror.stream.centos.org/9-stream/AppStream/ppc64le/os/Packages/libXaw-1.0.13-19.el9.ppc64le.rpm | ||
rpm -q libXt-devel || rpm -ivh --nodeps https://mirror.stream.centos.org/9-stream/AppStream/ppc64le/os/Packages/libXt-devel-1.2.0-6.el9.ppc64le.rpm | ||
rpm -q flex || rpm -ivh --nodeps https://mirror.stream.centos.org/9-stream/AppStream/ppc64le/os/Packages/flex-2.6.4-9.el9.ppc64le.rpm | ||
rpm -q bison || rpm -ivh --nodeps https://mirror.stream.centos.org/9-stream/AppStream/ppc64le/os/Packages/bison-3.7.4-5.el9.ppc64le.rpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UBI and CentOS may not be mixed in anything that Red Hat does, that's against Red Hat policy.
This PR adds support for installing TeX Live and Pandoc in the Jupyter notebook image for the ppc64le (IBM Power) architecture to enable PDF export functionality.
Key Changes:
Updated Dockerfile.cpu to:
Set the appropriate TeX Live path for Power
Validate pdflatex availability post-install
Ensured existing x86_64 logic is not affected.